Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] main from chromium:main #124

Merged
merged 48 commits into from
Dec 17, 2021
Merged

[pull] main from chromium:main #124

merged 48 commits into from
Dec 17, 2021

Conversation

pull[bot]
Copy link

@pull pull bot commented Dec 17, 2021

See Commits and Changes for more details.


Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

kenalba-google and others added 30 commits December 16, 2021 22:05
This is a reland of de046eb

Fixing browser test that broke in original, without symptoms on local
or tryjob runs; the fix in fake_data.js is directly equivalent to the
change in input_list_test.js.

Original change's description:
> input: Add keyboard details, top row, to input diagnostics
>
> Additions to input diagnostics backend, increasing detail
> for keyboards, particularly information about the top row
> key assignments, plus tweaks to number-pads.
>
> Bug: 1207678
> Test: ./out/Debug/ash_webui_unittests --gtest_filter=*InputDataProviderTest*
> Test: ./out/Debug/browser_tests --gtest_filter='DiagnosticsAppWithInput.*'
> Test: tested with subsequent patches on Jinlon, for internal and external keyboards
> Change-Id: I88d4e1051227d3226d51f88a58c0fc903a6d4975
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3299112
> Reviewed-by: Reilly Grant <reillyg@chromium.org>
> Reviewed-by: Ken Rockot <rockot@google.com>
> Reviewed-by: Harry Cutts <hcutts@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Auto-Submit: Kenneth Albanowski <kenalba@google.com>
> Reviewed-by: Gary Kacmarcik <garykac@chromium.org>
> Commit-Queue: Kenneth Albanowski <kenalba@google.com>
> Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#952129}

Bug: 1207678
Test: ./out/Debug/browser_tests --gtest_filter='DiagnosticsAppWithInput.*'
Change-Id: I9ff398a59e38cb96b47476cd26695387421134f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3344386
Reviewed-by: Harry Cutts <hcutts@chromium.org>
Reviewed-by: Gary Kacmarcik <garykac@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Kenneth Albanowski <kenalba@google.com>
Cr-Commit-Position: refs/heads/main@{#952533}
This change allows for preset metric data to be passed to the healthd
metric sampler. This can be used in instances where a bit of info or
telemetry is partially set by data collected from the health daemon and
partially set somewhere else.

Bug: b:201060765
Change-Id: Id09c3d18f9573b101ad311099e0cc2dc64273a98
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3345262
Reviewed-by: Leonid Baraz <lbaraz@chromium.org>
Commit-Queue: Tyler Garrett <tylergarrett@chromium.org>
Cr-Commit-Position: refs/heads/main@{#952534}
It turns out that EditableInputConnection, which is used internally by
EditText, has had an off-by-one bug that fails to return "false" as
requested in the API document when its internal batch edit count
becomes 0 [1].

Although the bug is finally fixed in the ToT of Android OS [2] and
expected to be shipped in a future version, it takes time for the fix
to be delivered to our test environment, which is Robolectric for
EditableInputConnection.  Even worth, when the fix is delivered some
tests would start failing because they assume the broken OS behavior.

In order to avoid sudden test failures in the future, this CL aims to
abstract out such an OS bug from our high level test expectations by
dynamically checking whether such a bug still exists or not at
runtime.  In this way, each test can focus on its own business logic
without worrying about the broken OS behavior.  A bonus is that we can
even test those two different OS behaviors in the future for free just
by specifying multiple SDK versions to the test runner [3].

Other than that, there should be no change in the high level
expectations of those tests.

 [1]: https://issuetracker.google.com/issues/209958658
 [2]: https://android-review.googlesource.com/c/platform/frameworks/base/+/1923058
 [3]: http://robolectric.org/configuring/

Bug: 209008342
Test: ninja -C out/Default chrome_junit_tests && out/Default/bin/run_chrome_junit_tests -f *AutocompleteEditTextTest.*
Change-Id: I23367c39af867fc5251e403f2e17ba324d65dc07
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330592
Reviewed-by: Shimi Zhang <ctzsm@chromium.org>
Reviewed-by: Tomasz Wiszkowski <ender@google.com>
Commit-Queue: Tomasz Wiszkowski <ender@google.com>
Cr-Commit-Position: refs/heads/main@{#952535}
In GTK4, the "decoration" node is removed and the frame shadow is drawn
directly on the window.  Additionally, the window contents are clipped
by the window shape instead of being drawn over the window.  This means
the corner radius computation must also be adjusted.

R=sky

Bug: None
Change-Id: I5aa97434b66bbd9c04d1b22c3ba958d3d79e5451
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3340172
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/main@{#952536}
Disable test due to flakiness. Seems like result_ids order is flipped

Bug: 1280531
Change-Id: I60d9b192215995d77263fcf6b17af4e6621646b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3345631
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#952537}
1. Allow thread safe access to a vulkan queue from gpu main thread
and drdc thread by using locks around all queue access. This
includes using locks in all vkQueue* api calls.

2. Use a map to generate lock per queue.

3. Update gpu/vulkan/generate_bindings.py to autogenerate relevant code.

Bug: 1262385
Change-Id: Icd730759d863522981fd14ea6e39fadb67c70365
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339655
Reviewed-by: Peng Huang <penghuang@chromium.org>
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Commit-Queue: vikas soni <vikassoni@chromium.org>
Cr-Commit-Position: refs/heads/main@{#952538}
Add the new flatland ozone directory to ozone_fuchsia, which was
renamed from ozone_scenic to represent both Flatland and Scenic.

Change-Id: I25d8a0d6fdcf80dc933b3494d483a8eaacb5c814
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339169
Auto-Submit: David Dorwin <ddorwin@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#952539}
Adds a DeviceImageInfo class which will be used by ash/quick_pair to
pass downloaded device images to the CrOS Bluetooth Config. These
images will then be passed to the UX to display device images in
Settings.

Change-Id: I39fe45da7484fb48982405739e7bd93e0aedc2c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3328735
Reviewed-by: Gordon Seto <gordonseto@google.com>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Daniel Classon <dclasson@google.com>
Cr-Commit-Position: refs/heads/main@{#952540}
Adds the "Sending..." animation from the send tab to self icon. This
will be shown when a device is selected in the send tab to self dialog.

Bug: 1265682
Change-Id: Id37e6e0cbeaf2109f691716c06e0a36f1eae62be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3345617
Commit-Queue: Kristi Park <kristipark@chromium.org>
Reviewed-by: Jeffrey Cohen <jeffreycohen@chromium.org>
Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org>
Cr-Commit-Position: refs/heads/main@{#952541}
This patch ensures that we can inherit the value from any parent,
even if the value itself has no effect on the parent.

R=ikilpatrick@chromium.org, chrishtr@chromium.org

Change-Id: I26586956884a1b8b922e9fce75ee4ad408cb4798
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3335076
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Vladimir Levin <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#952542}
This CL tweaks the ResponseAnalyzerTest::RunAnalyzerOnScenario method,
so that it takes an abstract ResponseAnalyzer interface as input
(instead of taking a concrete CorbResponseAnalyzer before this CL).
This CL helps with adding ORB test coverage in follow-up CLs.

This CL removes CorbResponseAnalyzer::canonical_mime_type accessor.
Note that the canonical MIME type is already covered by the following
tests:
- The CrossOriginReadBlockingTest.GetCanonicalMimeType unit test
  in //services/network/public/cpp/corb/corb_impl_unittest.cc
- UMA-based coverage via
    - The ResponseAnalyzerTest.ResponseBlocking unit test in
      //services/network/public/cpp/corb/corb_impl_unittest.cc
    - The InspectHistograms helper function used by the browser tests
      from //content/.../cross_site_document_blocking_browsertest.cc

Bug: 1178928
Change-Id: I2c0bbeb7bb6258318d852e07a28c1550b7bf89dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3334957
Reviewed-by: Charles Reis <creis@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/main@{#952543}
This CL implements change to add MEDIA_REQUEST_IOC_REINIT ioctl call.
This ioctl call re-initializes the previously allocated request to
recycle it for reuse.

Bug: b:202214561
TEST: v4l2_stateless_decoder --video crowd_run_256X144_fr15_bd8_8buf_l1_20210312.ivf --frames=1 on asurada
Change-Id: I9c866883f4ffc2c3c18f0cac89e33daec0b54154
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339624
Reviewed-by: Miguel Casas-Sanchez <mcasas@chromium.org>
Commit-Queue: Steve Cho <stevecho@chromium.org>
Cr-Commit-Position: refs/heads/main@{#952544}
https://skia.googlesource.com/skia.git/+log/3f95fd2ed8c4..44a839262076

2021-12-16 johnstiles@google.com Add breakpoint support in SkSL debugger.
2021-12-16 bsalomon@google.com Revert "Add support for explicit attribute offsets and strides."
2021-12-16 johnstiles@google.com Honor breakpoints while stepping over/out.
2021-12-16 johnstiles@google.com Implement 'stepToBreakpoint' in Trace player.
2021-12-16 jvanverth@google.com [graphite] Add background checks for iOS
2021-12-16 emaxx@chromium.org Fix use-after-move in DSLVarBase
2021-12-16 bsalomon@google.com Add support for explicit attribute offsets and strides.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC bungeman@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: chromium:1122844
Tbr: bungeman@google.com
Change-Id: Ia3c446db52e262dacc06914d809c0f3ad165f994
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3345744
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#952545}
…topsAfterEnteringCache on Mac

Bug: 1280741
Change-Id: I8411e4f48d332e179023afa068503f1c3aa04700
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3344011
Owners-Override: Roger McFarlane <rogerm@chromium.org>
Reviewed-by: Kelvin Jiang <kelvinjiang@chromium.org>
Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#952546}
Only the dpf/ top-level directory contains code that is used. Removing
the unused directories will avoid presubmit errors from unused code that
#includes files not allowed by the DEPS.

Bug: 1227772
Change-Id: I830db6c06e89f7b9ce32f2587bc26a5e087b9db1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3337416
Reviewed-by: Nan Lin <linnan@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Alex Turner <alexmt@chromium.org>
Auto-Submit: Alex Turner <alexmt@chromium.org>
Cr-Commit-Position: refs/heads/main@{#952547}
Report can just be bound to the callback, and this would make it easier
for reuse by aggregate reporting.

Change-Id: Iac3939e8a20e1bf3fdefd7864e59d90ecdef677c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3341346
Reviewed-by: Andrew Paseltiner <apaseltiner@chromium.org>
Commit-Queue: Andrew Paseltiner <apaseltiner@chromium.org>
Cr-Commit-Position: refs/heads/main@{#952548}
https://webrtc.googlesource.com/src.git/+log/03cb7e5a6124..977234879de7

2021-12-16 mbonadei@webrtc.org Trigger CI bots

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in WebRTC: https://bugs.chromium.org/p/webrtc/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: Ied17f076319f346a07d6dbd1364acbe0f69a64df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3345743
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#952549}
https://android.googlesource.com/platform/external/perfetto.git/+log/9c674c8ed684..cefb3e0ec3a0

2021-12-16 lalitm@google.com Merge "tp: add unaggregated camera memory metric"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: I580b45f778b3843b2e902c022869a7681cd02bb5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3345746
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#952550}
Previously within ShiftBreakpointIntoNextFragmentainer we'd always
assume the fragmentainer_space was definite.

Inside the initial column balancing pass this is incorrect. For this
case we set the fragmentainer_space to the row breakpoint such that
we'll position the items in the correct fragmentainer.

Added test grid-item-fragmentation-039 which would trigger the crash.
However this doesn't solve the issue as we are reporting an incorrect
block-size.

Bug: 614667
Change-Id: I155d744f92744e1196c70fb17179e3e2324fe63a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3343453
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/main@{#952551}
https://chromium.googlesource.com/catapult.git/+log/2c2d76537b02..d6ef4a8af654

2021-12-16 hypan@google.com Reland "Add the function to install privileged apps to devices"
2021-12-16 hypan@google.com Update the regex _EMULATOR_RE for DeviceUtils#is_emulator

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC wenbinzhang@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:1124965,chromium:1278096
Tbr: wenbinzhang@google.com
Change-Id: Ie2092190897b50ac8bd6b3b5cd1a8f8088cc5982
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3345750
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#952552}
…HandlingEmptyInlineVerticalRL

The same rebaseline as r952148 crrev.com/c/3341436 but for the `vertical-rl` variation.

Bug: 716930
Change-Id: Ia2fdefb8c06d8410e0718b450a50b25da489ef00
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3343697
Commit-Queue: Koji Ishii <kojii@chromium.org>
Auto-Submit: Koji Ishii <kojii@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/main@{#952553}
Add the component that will allocate and manage the D3D11Texture2D objects that are used by the Media Foundation Media Engine and provided to Chromium.

Bug: 1258887
Issue: 1258887
Change-Id: I609b13d029384e6fba709a5cbb210ec8fc9ca721
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3290069
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Rafael Cintron <rafael.cintron@microsoft.com>
Commit-Queue: Rafael Cintron <rafael.cintron@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#952554}
This moves permission_item from chromeos/os_apps_page/app_management to
cr_components/webapps so that it can be re-used by web app settings
page on Windows/Mac/Linux.

Functional changes:
- Removed store_client dependency for permission_item, passing app
directly via polymer data binding.
- Removed metrics_recorder dependency, only use util.js to
recordAppManagementUserAction.

Pure move:
- permission_item
- util.js excluding openAppDetailPage,openMainPage that rely on Router.
- permission_constants
- permission_util
- constants
- toggle_row
- shared_tyle
- shared_vars
- app_management.mojom

Change-Id: If54396080b4a7d2df248f0857a1d5a9ae2fe87c9
Bug: 1255194
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3311618
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Jeevan Shikaram <jshikaram@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: Phillis Tang <phillis@chromium.org>
Cr-Commit-Position: refs/heads/main@{#952555}
Bug: 1279890
Change-Id: I53d46ecc3f1eecc6dfe32d1c633a81e8ddc10bd3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339531
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Auto-Submit: Chris Lu <thegreenfrog@chromium.org>
Reviewed-by: Adam Trudeau-Arcaro <adamta@google.com>
Commit-Queue: Adam Trudeau-Arcaro <adamta@google.com>
Cr-Commit-Position: refs/heads/main@{#952556}
Using wpt-import in Chromium 20e77d0.
With Chromium commits locally applied on WPT:
6ed69eb "Migrate cookie-test.js's httpRedirectCookieTest to test_driver.delete_all_cookies"
7cd9af9 "Always assume that non-auto 'columns' might create a multicol."


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
R=rubber-stamper@appspot.gserviceaccount.com

No-Export: true
Change-Id: I2951404514fcaa9219bd3350026e6f55bca122d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3345664
Auto-Submit: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#952557}
Bug: 1280302
Change-Id: I1b45c63cf8c5a1e2d85a04db08287e8ef8ca7383
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3340720
Auto-Submit: Wez <wez@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/main@{#952558}
Bug: 1234054, 1220769
Change-Id: Iafd08c2592b26946a97089f4170bf71c8a857d16
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3261392
Reviewed-by: Sophie Chang <sophiechang@chromium.org>
Commit-Queue: Catherine Liu <catliu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#952559}
I added some VLOGs for crbug.com/1161996. As the investigation is done,
let's remove the VLOGs and/or turn the VLOGs to DVLOGs.

Bug: 1161996
Change-Id: I23a879536677c2f4313bfe2dfb01d188f0f5247d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3344528
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/main@{#952560}
https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/d81cd6236cd7..4ead61094cab

2021-12-16 rZhBoYao@gmail.com [libunwind] Provide a way to conveniently install libunwind headers

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/libunwind-chromium
Please CC thakis@chromium.org,hans@chromium.org on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Tbr: thakis@chromium.org,hans@chromium.org
Change-Id: Iaed5f865d1cabdb212ba307a105205d525bd2f81
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3343472
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#952561}
1) Mark navigations via Page.navigate from Chrome extensions as renderer-initiated.
2) Send DidAccessInitialDocument once CDP client attaches to avoid
spoofing of browser-initiated failed navigation.

A renderer-initiated pending URL is typically shown in the address bar above the initial about:blank page, until someone tries to modify the about:blank page, at which point it becomes a URL spoof risk. Since the DevTools protocol can be used to modify the initial about:blank page, its use should signal that the pending URL isn't safe to display.

Bug: 1192417
Change-Id: I585b69e59ed44fefb01d4216ead1c82c27c976af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3310854
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Charles Reis <creis@chromium.org>
Reviewed-by: Devlin Cronin <rdevlin.cronin@chromium.org>
Commit-Queue: Danil Somsikov <dsv@chromium.org>
Cr-Commit-Position: refs/heads/main@{#952562}
Henrique Nakashima and others added 18 commits December 16, 2021 23:16
The write was already in a separate thread, but edit() by itself it a
StrictMode violation. Move all the operation to a background thread.

Bug: 1262598
Change-Id: Iab9c5377dbe1e7c46ec5569c16d654ec3ef16d68
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3259299
Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Cr-Commit-Position: refs/heads/main@{#952563}
Bug: b:207588508
Change-Id: I23cbc59aa0af4d3898572698b3c50a6cccc53865
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3331228
Reviewed-by: Gordon Seto <gordonseto@google.com>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Theo Johnson-kanu <tjohnsonkanu@google.com>
Cr-Commit-Position: refs/heads/main@{#952564}
Adding browser tests for UrlHandlerAsh::OpenUrl which test
e.g. De-Duping of app creation.

BUG=1275776

Change-Id: I0efb0c8bccaa809b622780c3f23874d2596f750b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3331176
Reviewed-by: Erik Chen <erikchen@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Stefan Kuhne <skuhne@chromium.org>
Auto-Submit: Stefan Kuhne <skuhne@chromium.org>
Cr-Commit-Position: refs/heads/main@{#952565}
crrev.com/c/3322981 renamed various things related to the V8 sandbox.
This CL updates the chromium side accordingly.

Bug: 1218005
Change-Id: I514f9f5aa1f852aa51827536b2f8efa607118ea1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3329893
Reviewed-by: Camillo Bruni <cbruni@chromium.org>
Commit-Queue: Samuel Groß <saelo@chromium.org>
Cr-Commit-Position: refs/heads/main@{#952566}
This util class checks if the following option should be shown
and enabled.

Bug: 1279631
Change-Id: I7d9abf6cf48c451f4e4d4e67325ea6d8de0dc030
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3337083
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Tina Wang <tinazwang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#952567}
Bug: 1253843
Change-Id: Ia373b11397feff22c25c3d7013a2e11d5f207639
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3322136
Reviewed-by: David Pennington <dpenning@chromium.org>
Commit-Queue: Taylor Bergquist <tbergquist@chromium.org>
Cr-Commit-Position: refs/heads/main@{#952568}
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3f843f82c4b6..6b2cb689b53f

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC kelvinjiang@google.com,rogerm@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1249271
Tbr: kelvinjiang@google.com,rogerm@google.com
Change-Id: I45f0225c4c07cd20fdab0395a1cba465887aabf1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3345748
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#952569}
There appears to be a crash related to writing to NSUserDefaults off
the main thread at the same time a WebProcess is terminated.  Since
Chromium does a lot of NSUserDefaults on foreground and
backgrounding, and WebProcess terminatation also tends to happen
during foreground/backgrounding, the likelihood that these two things
happen at the same time is high.

A cursory investigation in WebKit didn't show anything obvious, but
it could be a bad interaction between CFPrefs direct mode usage
during a write to NSUserDefaults.

As a speculative short term fix, move the writing of our 2 top calls
to NSUserDefaults during foreground and background, and dispatch them
back to the main queue first.

Bug: 1247282, 1276578, 791690
Change-Id: I70a4cfe198bb7f3847dccdc983905bdfca72e286
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3341393
Reviewed-by: Ali Juma <ajuma@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/main@{#952570}
Adds the GIF asset and PNG thumbnail for the Tears of Joy  reaction for
the Lightweight Reactions feature.

Also changes the accessibility string of the existing Heart reaction
to "Beating Heart", in accordance with UXW guidance.

Bug: 1279915
Change-Id: Ifc7e3e6901e612f6e5e384a62718fa7ed82f45d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3345441
Reviewed-by: Sophey Dong <sophey@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Commit-Queue: Guillaume Jenkins <gujen@google.com>
Cr-Commit-Position: refs/heads/main@{#952571}
Make logic to wait for home screen animation more reliable - wait for an
extra frame after animation ends to ensure performance related
histograms get recorded.

BUG=1279744

Change-Id: Id418940f41e384c9b9aa4e27cb971b3a698fbd46
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3346100
Reviewed-by: Andrew Xu <andrewxu@chromium.org>
Commit-Queue: Toni Barzic <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/main@{#952572}
The xml description and approval already exists. This code was removed
during refactoring by mistake. Start recording this metric again.

Bug: 910374
Change-Id: I44b1d5035b054b1728c7efe1225915541cc843bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3345550
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Commit-Queue: Siddhartha S <ssid@chromium.org>
Cr-Commit-Position: refs/heads/main@{#952573}
Also show spinner while provisioning

screenshot: http://screen/5UAwg6KcprADnxm

Bug: 1198187
Change-Id: Ic52ebde7dd2166e5f9dc1f5cac2bad5e932fc1bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3343285
Reviewed-by: Gavin Dodd <gavindodd@google.com>
Commit-Queue: Gavin Williams <gavinwill@chromium.org>
Cr-Commit-Position: refs/heads/main@{#952574}
This change adds a LacrosPrefStore for ash. This PrefStore will exist
only in ash and holds prefs sent from lacros to ash. In particular, it
will be used to store extension-controlled prefs.

In a follow-up, this PrefStore will be persisted. It is not persisted or
used in this change.

Bug: 1218145
Change-Id: I4914bd4080841a7148259c368ae0610686d9f862
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3287323
Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Reviewed-by: Devlin Cronin <rdevlin.cronin@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Ian Helmke <helmke@google.com>
Cr-Commit-Position: refs/heads/main@{#952575}
This CL introduces Av1VideoEncoder - an implementation of
media::VideoEncoder interface that uses libaom to encode
AV1 video format.

libaom API is similar to libvpx API, but it is sufficiently different
to make it impractical to generalize VpxVideoEncoder.

Av1VideoEncoder is also plugged into blink::VideoEncoder, so AV1
encoding can be tested with WebCodecsAv1Encoding feature flag.

Bug: 1208280
Change-Id: Ic5d6e0ae2041ec1cbc60a21746c4c390806f5cf1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3314358
Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Reviewed-by: Johann Koenig <johannkoenig@google.com>
Reviewed-by: James Zern <jzern@google.com>
Commit-Queue: Eugene Zemtsov <eugene@chromium.org>
Cr-Commit-Position: refs/heads/main@{#952576}
This is address the flaky issue of
bluetooth/requestDevice/blocklisted-service-in-filter.https.window.js
introduced in crrev.com/c/3322017, which later on got reverted in
crrev.com/c/3341457.

Bug: 994756, 1280218
Change-Id: I0756c7e55cb528b915d8651b2310aa6db1a9fa3b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3342745
Reviewed-by: Chris Mumford <cmumford@google.com>
Commit-Queue: Jack Hsieh <chengweih@chromium.org>
Cr-Commit-Position: refs/heads/main@{#952577}
…8.7-r1 to 98-4744.1-1639393599-benchmark-98.0.4758.8-r1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-orderfile-chromium
Please CC c-compiler-chrome@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Tbr: c-compiler-chrome@google.com
Change-Id: I04f2719d1b9c8ffad219ad74e83a8aed83ec4b4b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3346160
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#952578}
Needed for QueryTiles in order to eliminated the need to cache the async
result to prefs.

Bug: 1261158
Change-Id: I993a7f0c1670c4b0cf797c0ff9fd948beee0eb5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3342912
Reviewed-by: Siddhartha S <ssid@chromium.org>
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Commit-Queue: Hailey Wang <haileywang@google.com>
Cr-Commit-Position: refs/heads/main@{#952579}
All clients of that file are already migrated to TS.

By migrating to TS, the signature of $() and $all() methods is improved
to leverage generics and propagate types to the underlying
querySelector/querySelectorAll methods.

As part of this change discovered that the DownloadShelf UI was opting
out of some strict TS checks (by setting "strictNullChecks": false).
Removed the flag and fixed violations.

Bug: 1189595
Change-Id: I681d2506f6e6e9d6fb5e6bb46cf0b225ec42b7aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3344388
Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: John Lee <johntlee@chromium.org>
Commit-Queue: John Lee <johntlee@chromium.org>
Cr-Commit-Position: refs/heads/main@{#952580}
@pull pull bot added the ⤵️ pull label Dec 17, 2021
@pull pull bot merged commit 32de615 into FairyWorld:main Dec 17, 2021
pull bot pushed a commit that referenced this pull request Jul 20, 2022
…ommits)

https://chromium.googlesource.com/external/github.com/freetype/freetype2-testing.git/+log/fe2eddae6176..1ca0c99d25ae

$ git log fe2eddae6..1ca0c99d2 --date=short --no-merges --format='%ad %ae %s'
2022-05-23 drott Track VisitedSet at top level before colrv1_start_glyph (#127)
2022-01-11 bungeman Unquote cc and cxx when executing. (#126)
2022-01-09 bungeman Quote more strings. (#125)
2022-01-09 bungeman Build bzip2 correctly. (#124)
2022-01-06 bungeman Use CC and CXX, check for clang version. (#123)
2022-01-06 bungeman Allow ubsan with asan or by itself. (#122)
2021-12-29 bungeman Remove CMAKE_x_COMPILER from libcxx build. (#119)
2021-12-24 bungeman Drop support for git <= 2.14. (#112)
2021-12-24 bungeman Make --rebuild work correctly again. (#111)
2021-12-24 bungeman Use sanitize-coverage=0 not no-sanitize-coverage (#115)
2021-12-24 bungeman Choose exactly one of the exclusive fuzzers (#117)
2021-12-24 bungeman Add missing quotes to libcxx.sh (#116)
2021-12-18 bungeman Add trace-pc-guard to no-sanitize-coverage. (#114)
2021-12-16 bungeman Add llvm-project for MemorySanitizer build. (#113)
2021-12-10 bungeman Add MemorySanitizer build option. (#110)
2021-11-09 drott Update corpus files for COLRv1 again (#109)
2021-11-01 drott Update corpus files for COLRv1 (#108)

Created with:
  roll-dep src/third_party/freetype-testing/src

Change-Id: I358febbaa1933d6d56ad655f62702d67e4a6c0c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3777978
Commit-Queue: Ben Wagner <bungeman@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1026318}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.